Avoid converting string to color
authorCarl Schwan <carl@carlschwan.eu>
Fri, 17 Jan 2025 14:10:18 +0000 (15:10 +0100)
committerMatthieu Gallien <matthieu.gallien@nextcloud.com>
Wed, 22 Jan 2025 09:42:31 +0000 (10:42 +0100)
Use hex directly

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
src/gui/accountsettings.cpp
src/libsync/theme.cpp

index 47c8793794a4d3f60e830d376c48d9438e5203d7..6af3208d0269f02f08199c73515b83d0d1cb6990 100644 (file)
@@ -1140,7 +1140,7 @@ void AccountSettings::showConnectionLabel(const QString &message, QStringList er
         errors.prepend(message);
         auto userFriendlyMsg = errors.join(QLatin1String("<br>"));
         qCDebug(lcAccountSettings) << userFriendlyMsg;
-        Theme::replaceLinkColorString(userFriendlyMsg, QColor("#c1c8e6"));
+        Theme::replaceLinkColorString(userFriendlyMsg, QColor(0xc1c8e6));
         _ui->connectLabel->setText(userFriendlyMsg);
         _ui->connectLabel->setToolTip({});
         _ui->connectLabel->setStyleSheet(errStyle);
index 7e717bf05f1be10ca479abaed722ae5396ba6149..7850f7ff03abe642af6108c749518c92cf4dad7b 100644 (file)
@@ -277,7 +277,7 @@ QIcon Theme::themeIcon(const QString &name, bool sysTray) const
             if (qgetenv("DESKTOP_SESSION") == "ubuntu") {
                 QBitmap mask = px.createMaskFromColor(Qt::white, Qt::MaskOutColor);
                 QPainter p(&px);
-                p.setPen(QColor("#dfdbd2"));
+                p.setPen(QColor(0xdfdbd2));
                 p.drawPixmap(px.rect(), mask, mask.rect());
             }
             cached.addPixmap(px);
@@ -870,7 +870,7 @@ bool Theme::isDarkColor(const QColor &color)
 
 QColor Theme::getBackgroundAwareLinkColor(const QColor &backgroundColor)
 {
-    return {(isDarkColor(backgroundColor) ? QColor("#6193dc") : QGuiApplication::palette().color(QPalette::Link))};
+    return {(isDarkColor(backgroundColor) ? QColor(0x6193dc) : QGuiApplication::palette().color(QPalette::Link))};
 }
 
 QColor Theme::getBackgroundAwareLinkColor()